[Tarantool-patches] [PATCH v2 luajit 2/6] test: introduce module for C tests

Sergey Bronnikov sergeyb at tarantool.org
Mon May 29 17:38:39 MSK 2023


This patch is LGTM after fixing typo below.

On 5/29/23 13:03, Sergey Kaplun wrote:
>
>>> ===================================================================
>> This test checks that macroses/functions in test.h could be called and
>> nothing more.
>>
>> We need checking TAP output that binary will emit for different test
>> statuses, plan, testcase counters ("1..10").
> As discussed offline: its not the main goal of this suite introducing,
> also, TAP13 protocol is tested by `prove` itself, and fully compatible
> with TAP14 protocol. Also, added the following check of parsing to be
> sure in the emmited format correctness.
>
> ===================================================================
> diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt
> index bf98856f..1aade851 100644
> --- a/test/tarantool-c-tests/CMakeLists.txt
> +++ b/test/tarantool-c-tests/CMakeLists.txt
> @@ -36,6 +36,9 @@ add_custom_command(TARGET tarantool-c-tests
>       ${CMAKE_CURRENT_BINARY_DIR}
>       --ext ${C_TEST_SUFFIX}
>       --jobs ${CMAKE_BUILD_PARALLEL_LEVEL}
> +    # Reportt any TAP parse errors, if any, since test module is

Typo: Reportt -> Report


> +    # maintained by us.
> +    --parse
>       ${C_TEST_FLAGS}
>     WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
> ===================================================================
>
> Also, mentioned this in the commit message:
>
> | The library itself is tested via some primitive tests for `ok` case,
> | `skip` and `todo` directives. The TAP13 format is tested via prove, that
> | we are using for running our tests. TAP14 format is compatible with
> | TAP13, so there are no other tests required.
>
>
> <snipped>
>


More information about the Tarantool-patches mailing list