[Tarantool-patches] [PATCH luajit 0/2] Fix canonicalization of +-0.0 keys for IR_NEWREF.
skaplun at tarantool.org
Wed May 10 15:34:57 MSK 2023
The backported commit needs to be checked precisely -- we don't want to
just check that the assertion failures are gone -- some commits  may
replace the aforementioned assertions with `return 0` or something else
 due to other issues. Hence, we need to be sure that there is no such
IR as "NEWREF.*-0" for these traces anymore. So the first commit
introduces new utility module for tests to parse traces dumped into the
file. There is nothing too fancy -- for now, the returned traces may
only say is there some particular IR or no. Any other features may be
added in the future uses, if we need.
Q: Can we use `jit.dump()` as is, without temporary file?
A: Yes, but no:
`jit.dump()` may be easily patched to use a custom object as the
second argument, not only file name. But this module dumps trace
information not by lines but more iterative. So we can use the
similar approach as in <luajit-gdb.py> -- concat each line and only
then dump it. But I don't ready to discuss this opportunity with Mike
now:). So, for now just use a temporary file and remove it after
Taranrool PR: https://github.com/tarantool/tarantool/pull/8634
Mike Pall (1):
Fix canonicalization of +-0.0 keys for IR_NEWREF.
Sergey Kaplun (1):
test: add utility for parsing `jit.dump`
src/lj_record.c | 2 +
.../tarantool-tests/lj-981-folding-0.test.lua | 57 +++++++
test/tarantool-tests/utils/jit_parse.lua | 156 ++++++++++++++++++
3 files changed, 215 insertions(+)
create mode 100644 test/tarantool-tests/lj-981-folding-0.test.lua
create mode 100644 test/tarantool-tests/utils/jit_parse.lua
More information about the Tarantool-patches