[Tarantool-patches] [PATCH luajit] LJ_GC64: Make ASMREF_L references 64 bit.

Sergey Kaplun skaplun at tarantool.org
Wed May 3 11:40:01 MSK 2023

Hi, Sergos!
Thanks for the review!

On 03.05.23, sergos wrote:
> Hi!
> Thanks for the patch!
> Since test is x86_64 only - can we put an explicit skipcond then?

We have two sides of the same coin here:

There is no bug for arm64, but some source code for this IR still
exists. Yes, we don't see any influence of the patch on arm64.

But, OTOH, we sure that there will be no regression in the future. As
far as changed code in the patch is platform independent, I prefer to
avoid skipcond here.

So, ignoring for now.

> Otherwise LGTM.
> Sergos.



Best regards,
Sergey Kaplun

More information about the Tarantool-patches mailing list