[Tarantool-patches] [PATCH luajit] Limit path length passed to C library loader.

Igor Munkin imun at tarantool.org
Thu Mar 30 20:36:03 MSK 2023


Max,

Thanks for the patch! LGTM, considering the fixes for Sergey comments.

On 16.03.23, Maksim Kokryashkin via Tarantool-patches wrote:
> From: Mike Pall <mike>
> 
> (cherry-picked from commit 90e65514dda3994253c1e3007f63da7ace8f6b7b)
> 
> C library loader uses `dlopen` under the hood, which fails, if
> provided library path is longer than PATH_MAX. PATH_MAX is
> 4096 bytes by default, so a corresponsing check is added to
> `ll_loadfunc`.
> 
> Maxim Kokryashkin:
> * added the description and the test for the problem
> 
> Part of tarantool/tarantool#8069
> ---
> Side note: Still no adequate constants like PATH_MAX...
> Side note: There is no test for successfull loadlib, since
> there is one in the PUC-Rio suite.
> 
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/c-library-path-length
> PR: https://github.com/tarantool/tarantool/pull/8449
> 
>  src/lib_package.c                                   |  7 ++++++-
>  test/tarantool-tests/c-library-path-length.test.lua | 13 +++++++++++++
>  2 files changed, 19 insertions(+), 1 deletion(-)
>  create mode 100644 test/tarantool-tests/c-library-path-length.test.lua
> 

<snipped>

> -- 
> 2.37.1 (Apple Git-137.1)
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list