[Tarantool-patches] [PATCH v1 luajit 1/5] test: fix setting of {DY}LD_LIBRARY_PATH variables

Maxim Kokryashkin m.kokryashkin at tarantool.org
Mon Mar 20 16:54:50 MSK 2023


Hi!
Thanks for the patch!
LGTM, except for the commit message.
 
 
  
>Среда, 15 марта 2023, 19:14 +03:00 от Sergey Kaplun <skaplun at tarantool.org>:
> 
>When we set `LUA_TEST_ENV_MORE` variable to be used in the additional
>env command for run testing if `"` is used to wrap `LD_LIBRARY_PATH`
Typo: s/wrap/wrap the
>value the content of this environment variable is literally
>`"/abs/path1:/abs/path2:...:". So, the first entry is treated as the
Typo: I guess you have forgot a ` here.
>relative path starting with `"`. In that case if we need to library to
Typo: s/to library/the library
>be loaded via FFI for this particular test, that loading fails with the
>error "cannot open shared object file", since the path to it is
>incorrect.
>
>This patch removes `"` wrapping for the aforementioned variables.
>---
--
Best regards,
Maxim Kokryashkin
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20230320/ec8d74a8/attachment.htm>


More information about the Tarantool-patches mailing list