[Tarantool-patches] [PATCH luajit v2 2/5] build: fix build with JIT disabled

Igor Munkin imun at tarantool.org
Thu Mar 2 18:52:17 MSK 2023


Thanks for your review!

On 01.03.23, Maxim Kokryashkin wrote:
> Hi, Igor!
> Thanks for the patch!
> LGTM, except for a few nits reagrding the commit message.
>> >>struct GCtrace is defined only if LJ_HASJIT is set. Hence, all spots
> >Typo: s/struct GCtrace/`struct GCtrace`

I can't remember whether I used this syntax in my commit messages.
Furthermore, there is no strict rules in our guidelines regarding code
references. Ignoring.

> >>where GCtrace is used should be also moved under LJ_HASJIT define.
> >Typo: s/should be also/should also be


> >>
> >>Relates to tarantool/tarantool#8252
> >>
> >>Signed-off-by: Igor Munkin < imun at tarantool.org >


> >--
> >Best regards,
> >Maxim Kokryashkin
Best regards,

More information about the Tarantool-patches mailing list