[Tarantool-patches] [PATCH v3 luajit 2/6] test: introduce module for C tests

Sergey Bronnikov sergeyb at tarantool.org
Wed Jun 7 18:51:06 MSK 2023


On 6/5/23 18:08, Sergey Bronnikov via Tarantool-patches wrote:
> Sergey,
>
> thanks for patches and fixes. See my comments below.
>
> On 6/5/23 13:41, Sergey Kaplun wrote: 
<snipped>
>> It's functionality inspired by CMocka API [1], but only TAP14 [2]
>> protocol is supported (Version of TAP set to 13 to be compatible with
>> old TAP13 harnesses).
>>
>> The group of unit tests is declared like the following:
>>
>> | void *t_state = NULL;
>> | const struct test_unit tgroup[] = {
>> |     test_unit_new(test_base),
>
> As I proposed in discussion verbally, I suggest to remove postfix 
> "_new" because
>
> we have opposite function with destructor ("test_unit_delete").
>
>
there is a typo. I mean "we have *no* opposite function with destructor"


More information about the Tarantool-patches mailing list