[Tarantool-patches] [PATCH luajit v2 3/5] test: introduce test:done TAP helper

[Igor Munkin]

Sergey,

Thanks for your review! Fixed all the typos you've found.

On 26.07.23, Sergey Kaplun wrote:
> Hi, Igor!
> Thanks for the patch!
> LGTM, except a minor nits regarding the commit message.
> 
> On 21.07.23, Igor Munkin wrote:

<snipped>

> > +local function done(test, exit)
> > +  if exit then
> > +    -- XXX: The second argument is required to properly close Lua
> > +    -- universe (i.e. invoke <lua_close> before exiting).
> > +    -- XXX: return is added explicitly to force CALLT emitting.
> 
> Side note: Is there a place, where it is important?

No, there's not. Prosto po prikolu.

> 
> > +    return os.exit(test:check() and 0 or 1, true)
> > +  else
> > +    assert(test:check(), 'Test check failed')
> > +  end
> > +end
> 
> <snipped>
> 
> > -- 
> > 2.30.2
> > 
> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM