[Tarantool-patches] [PATCH 1/2] test: fix typos
Sergey Bronnikov
sergeyb at tarantool.org
Fri Jul 14 15:36:40 MSK 2023
Thanks for review!
Updated branch force-pushed.
On 7/14/23 14:53, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except some comments below:
>
> 1) I suppose it should be named `refactoring: fix typos`, since we also
> changed debugger scripts and tools files. Feel free to split this commit
> into three for each subsystem, but I see no need in this.
Agreed offline to change to "codehealth".
> On 11.07.23, Sergey Bronnikov wrote:
>> From: Sergey Bronnikov <sergeyb at tarantool.org>
>>
>> Fix typos found with codespell in a files with our own source code.
> Typo: s/a files/files/
Fixed!
<snipped>
>> diff --git a/tools/memprof/process.lua b/tools/memprof/process.lua
>> index 0bcb965b..9dc202ae 100644
>> --- a/tools/memprof/process.lua
>> +++ b/tools/memprof/process.lua
>> @@ -39,8 +39,8 @@ function M.form_heap_delta(events, symbols)
>> for _, heap_chunk in pairs(event.primary) do
>> local ev_line = symtab.demangle(symbols, heap_chunk.loc)
>>
>> - if (heap_chunk.alloced > 0) then
>> - dheap[ev_line].dbytes = dheap[ev_line].dbytes + heap_chunk.alloced
>> + if (heap_chunk.allocated > 0) then
>> + dheap[ev_line].dbytes = dheap[ev_line].dbytes + heap_chunk.allocated
>> dheap[ev_line].nalloc = dheap[ev_line].nalloc + heap_chunk.count
>> end
> 2) Can we avoid such changes in the not-string/non-comment chunks?
I suppose no in checkpatch. These typos were found by manual codespell run.
More information about the Tarantool-patches
mailing list