[Tarantool-patches] [PATCH luajit] FFI: Fix recording of union initialization.

Sergey Kaplun skaplun at tarantool.org
Thu Jul 13 13:30:08 MSK 2023


Hi, Maksim!
Thanks for the patch!
LGTM, after fixing the Sergey's comment regarding the test description.

On 13.07.23, Sergey Bronnikov wrote:
> Hi, Max!
> 
> 
> thanks for the patch!
> 
> See my comments inline.
> 
> 
> Sergey
> 
> On 7/10/23 18:56, Maksim Kokryashkin wrote:
> > From: Mike Pall <mike>
> >
> > Thanks to Alex Shpilkin.
> >

<snipped>

> > +for i = 1, NITERATIONS do
> > +  test:ok(union_type(i).u == i)
> testcases description is missed, please add one.
> > +end
> > +
> > +os.exit(test:check() and 0 or 1)

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list