[Tarantool-patches] [PATCH luajit 1/3] sysprof: fix interval parsing in dual-number mode

Sergey Kaplun skaplun at tarantool.org
Mon Jan 30 12:39:15 MSK 2023


Hi, Sergos!
Thanks for the review!

On 26.01.23, sergos wrote:
> Hi!
> 
> Just a nit in message, LGTM.
> 
> Sergos
> 
> > On 18 Jan 2023, at 23:16, Sergey Kaplun <skaplun at tarantool.org> wrote:
> > 
> > When the profiling interval is parsed, `tvisnum()` is used to check that
>        a

Fixed, thanks!

>   
> > the given value is a number. But in case of dual-number mode this check
> > returns false as far as the given value is an integer, so `tvisnumber()`
> > should be used to cover both cases.
> > ---

<snipped>

> 

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list