[Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing

Igor Munkin imun at tarantool.org
Mon Jan 16 10:53:48 MSK 2023


Max,

Thanks for your review! I've fixed all nits you've left below.

On 13.01.23, Maxim Kokryashkin wrote:
> 
> Hi, Igor!
> Thanks for the patch!
> LGTM, except for a few nits below.

Added your tag:
| Reviewed-by: Maxim Kokryashkin <m.kokryashkin at tarantool.org>

>  

<snipped>

> >>"regular" ones need to be chosen for full LuaJIT testing. At the same
> >>time there is no need to use "regular" runner for LuaJIT Static analysis
> >>workflow, hence 'lightweight' label is added to <runs-on> list in
> >>lint.yml workflow file.
> >Shall we create the same patch for the gnumake workflow?

We definitely do, *but* the new 'lightweight' label is set only for
x86_64 machines at the moment. It this approach is extended for all
other arch flavors, GNU Make workflow will be updated.

> >>

<snipped>

> >--
> >Best regards,
> >Maxim Kokryashkin
>
-- 
Best regards,
IM


More information about the Tarantool-patches mailing list