[Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing
skaplun at tarantool.org
Fri Jan 13 10:10:48 MSK 2023
Thanks for the patch!
LGTM, with a single question below.
On 13.01.23, Maxim Kokryashkin wrote:
> Hi, Igor!
> Thanks for the patch!
> LGTM, except for a few nits below.
> >>Before the patch the all LuaJIT testing jobs were dispatched to the
> >Typo: s/the all/, all/
> >>runner with the name given via strategy matrix <RUNNER> entry. However,
> >Typo: s/via/via the/
> >>more convenient way for dispatching is the triplet of the following
> >Typo: s/more/a more/
> >>* <matrix.ARCH> to specify the host architecture (i.e. x86_64 or ARM64)
> >>* <matrix.OS> to specify the OS family name (either Linux or macOS)
> >>* 'self-hosted' to make job dispatch only to the runners from Tarantool
> >> ghacts-shared-* pool and never choose GitHub public resources.
> >>With the given triplet the proper runner is chosen for the particular
> >>testing flavor.
> >>Moreover, the new 'lightweight' and 'regular' labels are also used in
> >><runs-on> list, since the new "lightweight" runners have been introduced
> >>to ghacts-shared-* pool. There are a couple of LuaJIT tests that
> >>requires more memory than provided by "lightweight" runners, so only
> >Typo: s/requires/require/
> >Typo: s/than/than is/
> >>"regular" ones need to be chosen for full LuaJIT testing. At the same
> >>time there is no need to use "regular" runner for LuaJIT Static analysis
> >>workflow, hence 'lightweight' label is added to <runs-on> list in
> >>lint.yml workflow file.
> >Shall we create the same patch for the gnumake workflow?
I agree here. IMHO, we can use "lightweight" label for gnumake build as
far as it tests only build, so doesn't require a lot of memory.
> >>Signed-off-by: Igor Munkin < imun at tarantool.org >
> >> .github/workflows/gnumake-builds-testing.yml | 20 ++------------------
> >> .github/workflows/lint.yml | 2 +-
> >> .github/workflows/testing.yml | 20 ++------------------
> >> 3 files changed, 5 insertions(+), 37 deletions(-)
> >>diff --git a/.github/workflows/gnumake-builds-testing.yml b/.github/workflows/gnumake-builds-testing.yml
> >>index ad9d5015..e5f82780 100644
> >>--- a/.github/workflows/gnumake-builds-testing.yml
> >>+++ b/.github/workflows/gnumake-builds-testing.yml
> >>diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
> >>index e565144c..02150922 100644
> >>--- a/.github/workflows/lint.yml
> >>+++ b/.github/workflows/lint.yml
> >>diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
> >>index 958f8e27..5558e3ea 100644
> >>--- a/.github/workflows/testing.yml
> >>+++ b/.github/workflows/testing.yml
> >Best regards,
> >Maxim Kokryashkin
More information about the Tarantool-patches