[Tarantool-patches] [PATCH luajit 4/5] test: introduce test:skiprest TAP helper

Sergey Kaplun skaplun at tarantool.org
Mon Feb 27 12:56:15 MSK 2023

Hi, Igor!

Thanks for the patch!
LGTM, except a single nit regarding the commit message.

On 27.02.23, Igor Munkin wrote:
> Sometimes one need to skip the remaining tests in the script. There is

Typo: s/need/needs/

> no special stub in TAP13 protocol for this, but this could be done via
> skipping all the remaining planned tests.
> Within this commit <test:skiprest> helper is introduced that calls
> <test:skip> (planned - total) times and exits the test script. As for
> the previous commit it's worth to mention, that skiprest helper is
> implemented only for root (i.e. test with no parent) tests and subtests
> are not supported at the moment. The corresponding assertion with FIXME
> reason can be found in <finalize> routine.
> Signed-off-by: Igor Munkin <imun at tarantool.org>


Best regards,
Sergey Kaplun

More information about the Tarantool-patches mailing list