[Tarantool-patches] [PATCH luajit 2/7] build: fix build with JIT disabled

Igor Munkin imun at tarantool.org
Mon Feb 27 12:15:34 MSK 2023


Sergey,

Thanks for your review!

On 13.02.23, Sergey Kaplun wrote:
> Hi, Igor!
> Thanks for the patch!
> LGTM, except a single nit regarding the commit message.
> 
> On 13.02.23, Igor Munkin wrote:
> > struct GCtrace is defined only if LJ_HASJIT is set. Hence all spots
> 
> Typo: s/Hence,/Hence/

Fixed, force-pushed.

> 
> > where GCtrace is used should be also moved under LJ_HASJIT define.
> > 
> > Relates to tarantool/tarantool#8252
> 
> Side note: I see "Relates" and "Related" in our commit logs, so I
> suggest to use "Relates" for future commits.

I always use "Relates" (except maybe some early commits).

> 
> > 
> > Signed-off-by: Igor Munkin <imun at tarantool.org>
> 
> <snipped>
> 
> > -- 
> > 2.30.2
> > 
> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list