[Tarantool-patches] [PATCH luajit v2 4/6] memprof: remove unused arguments
Sergey Bronnikov
sergeyb at tarantool.org
Tue Dec 19 17:01:41 MSK 2023
Hello, Max
thanks for the patch! LGTM
On 12/6/23 21:55, Maxim Kokryashkin wrote:
> Both `humanize.profile_info` and `process.form_heap_delta`
> don't need the symtab, so the argument can be dropped.
>
> Part of tarantool/tarantool#5994
> ---
> tools/memprof.lua | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/memprof.lua b/tools/memprof.lua
> index e23bbf24..955a1327 100644
> --- a/tools/memprof.lua
> +++ b/tools/memprof.lua
> @@ -102,9 +102,9 @@ local function dump(inputfile)
> local symbols = symtab.parse(reader)
> local events = memprof.parse(reader, symbols)
> if not leak_only then
> - view.profile_info(events, symbols)
> + view.profile_info(events)
> end
> - local dheap = process.form_heap_delta(events, symbols)
> + local dheap = process.form_heap_delta(events)
> view.leak_info(dheap)
> view.aliases(symbols)
> -- XXX: The second argument is required to properly close Lua
More information about the Tarantool-patches
mailing list