[Tarantool-patches] [PATCH luajit v2 1/6] build: purge sysprof.collapse module
Sergey Bronnikov
sergeyb at tarantool.org
Tue Dec 19 15:20:07 MSK 2023
Thanks for the patch! LGTM with a minor comment.
I'm not sure "build" is a correct prefix for a small commit description.
Probably "tools" reflects component better.
On 12/6/23 21:55, Maxim Kokryashkin wrote:
> This module became unused as a result of commit
> tarantool/tarantool at e2851883cd4c23d41bd9aec23fad06fd10d39c45,
> so it can be purged safely from the LuaJIT sources.
>
> Part of tarantool/tarantool#8700
> ---
> tools/CMakeLists.txt | 6 ------
> tools/sysprof/collapse.lua | 3 ---
> 2 files changed, 9 deletions(-)
> delete mode 100755 tools/sysprof/collapse.lua
>
> diff --git a/tools/CMakeLists.txt b/tools/CMakeLists.txt
> index b951f767..1dfc39e4 100644
> --- a/tools/CMakeLists.txt
> +++ b/tools/CMakeLists.txt
> @@ -60,9 +60,6 @@ if(LUAJIT_DISABLE_SYSPROF)
> else()
> add_custom_target(tools-parse-sysprof EXCLUDE_FROM_ALL DEPENDS
> sysprof/parse.lua
> - # TODO: This line is not deleted only for the sake of integrational
> - # testing. It should be deleted in the next series.
> - sysprof/collapse.lua
> sysprof.lua
> utils/bufread.lua
> utils/symtab.lua
> @@ -71,9 +68,6 @@ else()
>
> install(FILES
> ${CMAKE_CURRENT_SOURCE_DIR}/sysprof/parse.lua
> - # TODO: This line is not deleted only for the sake of integrational
> - # testing. It should be deleted in the next series.
> - ${CMAKE_CURRENT_SOURCE_DIR}/sysprof/collapse.lua
> DESTINATION ${LUAJIT_DATAROOTDIR}/sysprof
> PERMISSIONS
> OWNER_READ OWNER_WRITE
> diff --git a/tools/sysprof/collapse.lua b/tools/sysprof/collapse.lua
> deleted file mode 100755
> index cac92f1a..00000000
> --- a/tools/sysprof/collapse.lua
> +++ /dev/null
> @@ -1,3 +0,0 @@
> --- FIXME: This file is not deleted only for the sake of
> --- integrational testing. It should be deleted in the
> --- next series.
More information about the Tarantool-patches
mailing list