[Tarantool-patches] [PATCH luajit 1/4] cmake: properly handle the memprof/process.lua
Sergey Kaplun
skaplun at tarantool.org
Tue Dec 5 11:44:20 MSK 2023
Hi, Maxim!
Thanks for the patch!
Please consider my comment below.
On 04.12.23, Maxim Kokryashkin wrote:
> Prior to this patch, memprof/process.lua wasn't added to the
> dependency list as a part of the memprof parser sources. Also,
> it wasn't installed into the system along with other memprof
> sources, which breaks the profile parser.
>
> Part of tarantool/tarantool#5994
> ---
> tools/CMakeLists.txt | 2 ++
I suppose this patch should also add <memprof/process.lua> to the
`FILES_MEMPROFLIB=` in the <Makefile.original>.
Also, we should add sysprof libraries to the original Makefile.
<snipped>
> --
> 2.43.0
>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list