[Tarantool-patches] [PATCH luajit] Fix TDUP load forwarding after table rehash.

Sergey Bronnikov sergeyb at tarantool.org
Mon Aug 28 17:33:35 MSK 2023


On 8/28/23 17:26, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
> Please, see my answers below.
>
> On 28.08.23, Sergey Bronnikov wrote:
>> Sergey,
>>
>>
>> thanks for the patch. See my comment inline.
>>
> <snipped>
>
>>
>> Is it possible to fold loop bodies to a single function?
>>
>> Otherwise it is too much duplicate code in the test.
> I prefer not to do it since:
> * It's complicated traces, so it's harder to understand what is this
>    test about.
> * Some function's may be recorded instead, so the issue will not
>    occure. Or test becomes flaky.
Okay, accepted. LGTM


More information about the Tarantool-patches mailing list