[Tarantool-patches] [PATCH luajit] Fix maxslots when recording BC_VARG, part 3.

Sergey Bronnikov sergeyb at tarantool.org
Mon Aug 28 16:15:55 MSK 2023


Hi, Sergey


thanks for your fixes proposed in [1], I like your suggested changes.

LGTM after fixing red CI, see in [2].


1. https://lists.tarantool.org/tarantool-patches/ZOTXyLt2x9FcXCt6@root/

2. 
https://github.com/tarantool/luajit/actions/runs/5950318637/job/16138150847


On 8/15/23 15:32, Sergey Kaplun wrote:
> From: Mike Pall <mike>
>
> Thanks to Peter Cawley.
>
> (cherry-picked from commit abb27c7771947e082c9d919d184ad5f5f03e2e32)
>
> In case, when `BC_VARG` set the VARG slot to the non-top stack slot,
> `maxslot` value was unconditionally set to the destination slot, so some
> top slots may be omitted in the snapshot entry. Since these slots are
> omitted, they are not restored correctly, when restoring from snapshot
> for this side exit.
>
> This patch adds the check for the aforementioned case, to avoid maxslot
> shrinking.
>

<snipped>



More information about the Tarantool-patches mailing list