[Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter

Igor Munkin imun at tarantool.org
Mon Aug 21 14:05:56 MSK 2023


Pals, thanks for your reviews!

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master, release/2.11 and
release/2.10.

On 03.08.23, Igor Munkin wrote:
> This series implements flak8 linter support for existing Python scripts
> in the repo (i.e. luajit-gdb.py and luajit_lldb.py). Almost all patches
> simply fix PEP8 violations found in our code, and the last patch of the
> series adds flake8 config, CMake subtarget to run flake8 in scope of the
> new <LuaJIT-lint> target and adjusts lint workflow respectively.
> 
> To be honest, not all of the errors reported by flake8 (or rather
> pycodestyle that is wrapped by flake8) are fixed at the moment. One can
> find some TODO entries in .flake8rc, since I've failed making flake8
> happy and have finally given up. If you have any ideas how to resolve
> these TODOs, you're very welcome.
> 
> Branch: https://github.com/tarantool/luajit/commits/imun/add-flake8
> 
> Igor Munkin (15):
>   test: fix E122 errors by pycodestyle
>   test: fix E128 errors by pycodestyle
>   test: fix E201 and E202 errors by pycodestyle
>   test: fix E203 errors by pycodestyle
>   test: fix E231 errors by pycodestyle
>   test: fix E251 errors by pycodestyle
>   test: fix E301 errors by pycodestyle
>   test: fix E302 errors by pycodestyle
>   test: fix E303 errors by pycodestyle
>   test: fix E305 errors by pycodestyle
>   test: fix E502 errors by pycodestyle
>   test: fix E711 errors by pycodestyle
>   test: fix E722 errors by pycodestyle
>   test: fix E741 errors by pycodestyle
>   test: run flake8 static analysis via CMake
> 
>  .flake8rc                  |  12 ++
>  .github/workflows/lint.yml |   4 +-
>  src/luajit-gdb.py          | 325 ++++++++++++++++++++++-------------
>  src/luajit_lldb.py         | 336 +++++++++++++++++++++++--------------
>  test/CMakeLists.txt        |  28 ++++
>  5 files changed, 458 insertions(+), 247 deletions(-)
>  create mode 100644 .flake8rc
> 
> -- 
> 2.30.2
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list