[Tarantool-patches] [PATCH luajit 13/19] ARM: Fix GCC 7 -Wimplicit-fallthrough warnings.

Sergey Kaplun skaplun at tarantool.org
Thu Aug 17 11:01:07 MSK 2023


Hi, Sergey!
Thanks for the review!

On 17.08.23, Sergey Bronnikov wrote:
> Hi, Sergey!
> 
> LGTM, but I have a question inline
> 
> 

<snipped>

> > +    AND CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL "7.1")
> 
> GCC 7.1 because there was no 7.0 in release series 7 [1], right?
> 
> 1. https://gcc.gnu.org/gcc-7/

Yes, just the first version with this option.

<snipped>

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list