[Tarantool-patches] [PATCH luajit 18/19] DynASM/MIPS: Fix shadowed variable.

Sergey Kaplun skaplun at tarantool.org
Wed Aug 16 18:22:31 MSK 2023


Hi, Maxim!
Thanks for the review!

On 16.08.23, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for the single typo in the commit message.
> On Wed, Aug 09, 2023 at 06:36:07PM +0300, Sergey Kaplun via Tarantool-patches wrote:
> > From: Mike Pall <mike>
> > 
> > Cleanup only, bug cannot trigger.
> > Thanks to Domingo Alvarez Duarte.
> > 
> > (cherry-picked from commit 5c911998a3c85d024a8006feafc68d0b4c962fd8)
> > 
> > This patch fixes local shadow variable `n` in `template__` function from
> Typo: s/local/the local/

Fixed, thanks!

> > <dynasm/dasm_mips.lua> by renaming it to `m`. Since this cannot be
> > triggered, there is no test provided.
> > 
> > Sergey Kaplun:
> > * added the description for the problem
> > ---

<snipped>

> > 2.41.0
> > 

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list