[Tarantool-patches] [PATCH luajit 11/19] Fix GCC 7 -Wimplicit-fallthrough warnings.

Sergey Kaplun skaplun at tarantool.org
Wed Aug 16 16:59:42 MSK 2023


Hi, Maxim!
Thanks for the review!
Fixed your comments inline.

On 15.08.23, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM as trivial, except for a few comments regarding the commit message below.
> On Wed, Aug 09, 2023 at 06:36:00PM +0300, Sergey Kaplun via Tarantool-patches wrote:
> > From: Mike Pall <mike>
> > 
> > (cherry-picked from commit d4ee80342770d1281e2ce877f8ae8ab1d99e6528)
> > 
> > This patch adds the `/* fallthrough */` where it may trigger the
> > `-Wimplicit-fallthrough` [1] warning. Some cases still not covered by
> Typo: s/cases still/cases are still/

Fixed, thanks!

> > this comment and will be fixed in the future commits.
> Typo: s/in the/in/

Fixed.

> > 
> > [1]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough
> > 
> > Sergey Kaplun:
> > * added the description for the commit
> > 
> > Part of tarantool/tarantool#8825
> > ---

<snipped>

> > 

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list