[Tarantool-patches] [PATCH luajit 09/19] FFI: Eliminate hardcoded string hashes.

[Sergey Kaplun]

Hi, Maxim!
Thanks for the review!
Fixed your comments inline.

On 15.08.23, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for a few comments below.
> 
> On Wed, Aug 09, 2023 at 06:35:58PM +0300, Sergey Kaplun via Tarantool-patches wrote:
> > From: Mike Pall <mike>
> > 
> > (cherry-picked from commit 70f4b15ee45a6137fe6b48b941faea79d72f7159)
> > 
> > This patch refactors FFI parsing of supported C attributes and pragmas,
> > `ffi.abi()` parameter check. It replaces usage of comparison (with
> Typo: s/usage/the usage/

Fixed.

> > hardcoded string hashes) with search in the given string with the
> Typo: s/with search/with a search/

Fixes.

> > format: "\XXXattribute1\XXXattribute2", where `\XXX` is the length of
> > "attribute" name.
> > 
> > Sergey Kaplun:
> > * added the description for the commit
> > 
> > Part of tarantool/tarantool#8825
> > ---

<snipped>

> > 

-- 
Best regards,
Sergey Kaplun