[Tarantool-patches] [PATCH luajit 07/19] build: fix non-Linux/macOS builds

Sergey Kaplun skaplun at tarantool.org
Wed Aug 16 16:40:12 MSK 2023


Hi, Maxim!
Thansk for the review!
Fixed your comments inline.

On 15.08.23, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for a few typos below.
> On Wed, Aug 09, 2023 at 06:35:56PM +0300, Sergey Kaplun via Tarantool-patches wrote:
> > This patch is a follow-up for the commit
> > a170eb8be9475295f4f67a086e25ed665b95c8ea ("core: separate the profiling
> > timer from lj_profile"). It moves the timer machinery to the separate
> Typo: s/to the/to a/

Fixed.

> > module. Unfortunately, the `profile_{un}lock()` calls for Windows and
> > PS3 wasn't updated to access `lj_profile_timer` structure instead of
> Typo: s/wasn't/weren't/

Fixed, thanks.

> > `ProfileState`.
> > 
> > Also, it is a follow-up to the commit
> > f8fa8f4bbd103ab07697487ca5cab08d57cdebf5 ("memprof: add profile common
> > section"). Since this commit the system-dependent header <unistd.h> and
> > `write()`, `open()`, `close()` functions are used. They are undefining
> Typo: s/undefining/undefined/

Fixed.

> > on Windows, so this leads to error during the build.
> Typo: s/error/errors/

Fixed.

> > 
> > This patch fixes the aforementioned misbehaviour. After it our fork may
> > be built on Windows at least.
> > ---

<snipped>

> > 

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list