[Tarantool-patches] [PATCH luajit v2] Fix narrowing of unary minus.

Sergey Kaplun skaplun at tarantool.org
Thu Sep 29 16:08:35 MSK 2022


Hi, Maxim!

Thanks for the fixes!
LGTM, just a single nit below.

On 29.09.22, Maxim Kokryashkin via Tarantool-patches wrote:
> 
> Hi, Sergos!
> Thanks for the questions!
> Please consider my answers amd changes below.

<snipped>

> Here is the diff:
> ===============================================
> --- a/test/tarantool-tests/gh-6976-narrowing-of-unary-minus.test.lua
> +++ b/test/tarantool-tests/gh-6976-narrowing-of-unary-minus.test.lua

<snipped>

> +test:ok(check(function()
> +  -- See the comment about `table.new()` above.
> +  local res = require('table.new')(3, 0)
> +  for i = 2, 0, -1 do
> +    table.insert(res, 1 / -i)
> +  end
> +  return res
> +end),'assertion guard fail')

Typo: s/,/, /

>  

<snipped>

> Best regards,
> Maxim Kokryashkin
>  

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list