[Tarantool-patches] [PATCH luajit] FFI: Add tonumber() specialization for failed conversions.

Maxim Kokryashkin m.kokryashkin at tarantool.org
Mon Sep 19 10:50:07 MSK 2022

Hi, Sergey!
Thanks for the patch!
LGTM, except for a single nit below:
>When `tonumber()` is recorded (as a part of a trace) for cdata argument
>can't be converted to number the `nil` value is recorded as the yielded
>result. But without special check on trace for cdata type this nil will
>be returned for another type of cdata that can be converted.
The first sentence lacks commas and is completely unreadable.
I suggest the following fix:
| When `tonumber()` is recorded (as a part of a trace) for a cdata argument that can't be converted to number, the `nil` value is | recorded as the yielded result.
>This patch adds the corresponding check for recoding of failed cdata
Typo: s/recoding/recording
Best regards,
Maxim Kokryashkin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20220919/29fb5305/attachment.htm>

More information about the Tarantool-patches mailing list