[Tarantool-patches] [PATCH luajit 3/6] OSX/ARM64: Disable external unwinding for now.
skaplun at tarantool.org
Mon Oct 3 14:08:37 MSK 2022
Thanks for the patch!
LGTM, with the several nits below.
On 26.09.22, Maksim Kokryashkin wrote:
> From: Mike Pall <mike>
> This reduces functionality, e.g. no handling of on-trace errors.
> Someone with very deep knowledge about macOS and MACH-O/DWARF stack
> unwinding internals is needed to fix this. See issue LuaJIT/LuaJIT#698.
Side note: I'm not sure that we should mention the LuaJIT issues in our
commit message -- every time you repush your branch, it adds another
mention in upstream (you can check :)). That's definitely not what Mike
Perhaps we should just mention the issue by number without a direct link
> (cherry picked from commit 27ee3bcd79b12a0c71f00427ee1a2e486c684486)
> ARM64 interpreter doesn't have unwind info for Mach-O assembler
> format, which makes unwinding impossible.
> For more info, see https://github.com/LuaJIT/LuaJIT/issues/698
Nit: missed dot in the end of the sentence.
> Maxim Kokryashkin:
> * added the description for the problem
> Needed for tarantool/tarantool#6096
> Needed for tarantool/tarantool#7230
Minor: s/Needed for/Part of/
> cmake/SetTargetFlags.cmake | 4 +++-
> src/Makefile.original | 5 ++++-
> 2 files changed, 7 insertions(+), 2 deletions(-)
> diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake
> index a5a3407f..d99e1f9a 100644
> --- a/cmake/SetTargetFlags.cmake
> +++ b/cmake/SetTargetFlags.cmake
> diff --git a/src/Makefile.original b/src/Makefile.original
> index d1373b40..5826a56a 100644
> --- a/src/Makefile.original
> +++ b/src/Makefile.original
> 2.32.1 (Apple Git-133)
More information about the Tarantool-patches