[Tarantool-patches] [PATCH luajit v2] Fix narrowing of unary minus.
Maxim Kokryashkin
m.kokryashkin at tarantool.org
Mon Oct 3 12:57:56 MSK 2022
Hi, Sergey!
I’ve fixed the nit you mentioned, the branch is force pushed.
--
Best regards,
Maxim Kokryashkin
>Четверг, 29 сентября 2022, 16:11 +03:00 от Sergey Kaplun <skaplun at tarantool.org>:
>
>Hi, Maxim!
>
>Thanks for the fixes!
>LGTM, just a single nit below.
>
>On 29.09.22, Maxim Kokryashkin via Tarantool-patches wrote:
>>
>> Hi, Sergos!
>> Thanks for the questions!
>> Please consider my answers amd changes below.
>
><snipped>
>
>> Here is the diff:
>> ===============================================
>> --- a/test/tarantool-tests/gh-6976-narrowing-of-unary-minus.test.lua
>> +++ b/test/tarantool-tests/gh-6976-narrowing-of-unary-minus.test.lua
>
><snipped>
>
>> +test:ok(check(function()
>> + -- See the comment about `table.new()` above.
>> + local res = require('table.new')(3, 0)
>> + for i = 2, 0, -1 do
>> + table.insert(res, 1 / -i)
>> + end
>> + return res
>> +end),'assertion guard fail')
>
>Typo: s/,/, /
>
>>
>
><snipped>
>
>> Best regards,
>> Maxim Kokryashkin
>>
>
>--
>Best regards,
>Sergey Kaplun
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20221003/f9ac11b1/attachment.htm>
More information about the Tarantool-patches
mailing list