[Tarantool-patches] [PATCH luajit v4 7/8] Fix build with busybox grep.

[Maxim Kokryashkin]

Hi!
Thanks for the review!
 
 
 
  
>Четверг, 24 ноября 2022, 15:00 +03:00 от Sergey Kaplun <skaplun at tarantool.org>:
> 
>Hi, Maksim!
>Thanks for the patch!
>
>LGTM, with a single nit below.
>
>On 28.10.22, Maksim Kokryashkin wrote:
>> From: Mike Pall <mike>
>>
>> Reported by ymph.
>>
>> (cherry picked from commit 66563bdab0c7acf3cd61dc6cfcca36275951d084)
>>
>> Busybox implementation of grep doesn't have the `-U` option, but it
>> has the option to treat the binary as a text file, so that case is
>
>Minor: the `-a` option
Fixed.
>
>> provided as an alternative.
>>
>> Maxim Kokryashkin:
>> * added the description for the problem and updated the CMake
>>
>> Needed for tarantool/tarantool#6096
>> Part of tarantool/tarantool#7230
>> ---
>> cmake/SetTargetFlags.cmake | 2 +-
>> src/Makefile.original | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake
>> index 943a3152..8abb6288 100644
>> --- a/cmake/SetTargetFlags.cmake
>> +++ b/cmake/SetTargetFlags.cmake
>
><snipped>
>
>> diff --git a/src/Makefile.original b/src/Makefile.original
>> index 4d7cda3e..2d014e43 100644
>> --- a/src/Makefile.original
>> +++ b/src/Makefile.original
>
><snipped>
>
>> --
>> 2.37.0 (Apple Git-136)
>>
>
>--
>Best regards,
>Sergey Kaplun
--
Best regards,
Maxim Kokryashkin
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20221130/98d72b03/attachment.htm>