[Tarantool-patches] [PATCH luajit] ci: introduce GitHub Actions

Igor Munkin imun at tarantool.org
Fri Mar 4 17:11:23 MSK 2022


Hey, it's me again.

On 02.03.22, Igor Munkin wrote:
> Max,
> 
> Thanks for your review!
> 

<snipped>

> > >
> > >So maybe we can use matrix to cover all these workflows as showing
> > >here[5], using environment variables to determine setup step for the
> > >particular OS (macOS or Linux)?
> > >
> > >But maybe I am overcomplicating things, so feel free to ignore. :)
> > I think that in our case it is actually better to have a lot of workflow configs.
> > From time to time we encounter some issues only on certain operating
> > systems, so it is great to have the ability to fine-tune workflow config only for
> > one particular OS.
> 
> Such cases should be handled in tests, not in workflows (consider
> Tarantool workflow using LuaJIT tests), so I've left one workflow per
> each supported OS (i.e. Linux and macOS). Ignoring.

Well, I was wrong, you were right -- there was a big mistake to merge
workflows for x86_64 and aarch64. At first, there is no support for the
latter in 1.10 and 2.8. Furthermore, macOS runners on m1 are using
Rosetta for Github Actions' workflows, so we need use `arch -arm64`
prefix for each command and I've failed to make it respect <matrix.ARCH>
variable.

So, I've reverted the related changes. Again, thanks for your inputs!

> 
> >  
> > Best regards,
> > Maxim Kokryashkin
> >  
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list