[Tarantool-patches] [PATCH v31 3/3] test: add gh-6036-qsync-order test

Cyrill Gorcunov gorcunov at gmail.com
Thu Mar 3 14:02:32 MSK 2022


On Thu, Mar 03, 2022 at 01:08:59PM +0300, Serge Petrenko wrote:
> 
> 02.03.2022 23:27, Cyrill Gorcunov пишет:
> > To test that promotion requests are handled only when appropriate
> > write to WAL completes, because we update memory data before the
> > write finishes.
> > 
> > Part-of #6036
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> 
> 
> Thanks for working on this!
> 
> Please consider the following cosmetic changes:
> 
> 1. There's build_and_add_server as an alias for build_server + add_server
> 
> 2. Use luatest.assert instead of plain assert everywhere
> 
> 3. Use exec instead of eval everywhere

Thanks a huge, Serge! Will update and force push.


More information about the Tarantool-patches mailing list