[Tarantool-patches] [PATCH luajit] Add stricter check for print() vs. tostring() shortcut.
Igor Munkin
imun at tarantool.org
Thu Jun 23 19:19:08 MSK 2022
Sergey,
Thanks for the patch! In addition to Sergos' nits regarding the commit
message, I have two regarding the test:
1. Why didn't you use <utils.selfrun> helper for your purposes? It
fits better than the pack of hacks implementing quite a similar
routine.
2. Test name should start with the corresponding issue number from
LuaJIT queue, AFAIR.
I fixed both comments within fixup commit on top of your branch[1].
Otherwise the patch LGTM, so if you're OK with the changes, I'll proceed
with it.
Last, but not least: I see no ChangeLog entry in the patch. Could you
please drop a few words regarding the change in this thread?
[1]: https://github.com/tarantool/luajit/commit/da9f089
--
Best regards,
IM
More information about the Tarantool-patches
mailing list