[Tarantool-patches] [PATCH luajit 1/3] ci: fix --parallel argument for MacOS runners

Sergey Kaplun skaplun at tarantool.org
Thu Jun 23 11:19:05 MSK 2022

Hi, Igor!

Thanks for the patch!

LGTM, except a few nits regarding the commit message.

On 22.06.22, Igor Munkin wrote:
> In scope of the commit 4195eb8f7e2abcf75f92eedd2859b7991cc8b363 ("ci:

Typo: s/In scope/In the scope/

> make GitHub workflows more CMake-ish") --parallel value has been
> explicitly set to $(nproc) + 1, since -j default behaviour differs for
> Ninja and GnuMake. However, MacOS lacks nproc command, but CI silently
> continues to execute pipeline.

Typo: s/pipeline/the pipeline/

> This patch fixed MacOS-specific workflows changing nproc command with

Nit: s/fixed/fixes/ as far as we prefer Present Simple for commits
Feel free to ignore.

> sysctl -n hw.ncpu.
> Signed-off-by: Igor Munkin <imun at tarantool.org>
> ---


> -- 
> 2.34.0

Best regards,
Sergey Kaplun

More information about the Tarantool-patches mailing list