[Tarantool-patches] [PATCH luajit v2] test: adapt disabled tests from PUC-Rio

[Igor Munkin]

Max,

LGTM, considering post-review fixes you've made as a result of Sergey
reply, but still some nits are remaining. Please, consider one of them
below; you can find several more in the reply to post-review fixes.

On 13.10.21, Maxim Kokryashkin wrote:

<snipped>

> ---
> Changes in v2:
> - Fixed comments as per review by Sergey
> - Disabled some tests for Tarantool
> - Added link to CI jobs
> 
> Issue: https://github.com/tarantool/tarantool/issues/5687
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-5687-adapt-tests-output-PUC-Rio
> CI: https://github.com/tarantool/tarantool/tree/fckxorg/gh-5687-adapt-disabled-tests-from-PUC-Rio
> 
>  test/PUC-Rio-Lua-5.1-tests/main.lua | 97 ++++++++++++++++++++---------
>  1 file changed, 66 insertions(+), 31 deletions(-)
> 
> diff --git a/test/PUC-Rio-Lua-5.1-tests/main.lua b/test/PUC-Rio-Lua-5.1-tests/main.lua
> index 07facc4c..38111560 100644
> --- a/test/PUC-Rio-Lua-5.1-tests/main.lua
> +++ b/test/PUC-Rio-Lua-5.1-tests/main.lua
> @@ -24,11 +24,33 @@ local prepfile = function (s, p)
>    assert(io.close())
>  end
>  
> -function checkout (s)
> +-- Taken from PUC-Rio Lua 5.2 test suite.
> +-- See comment for checkprogout().
> +function getoutput ()
>    io.input(out)
>    local t = io.read("*a")
>    io.input():close()
>    assert(os.remove(out))
> +  return t
> +end
> +
> +-- Version and status are printed in stdout instead stderr since

Typo: s/instead/instead of/.

> +-- LuaJIT-2.0.0-beta11 (as it is not an error message).
> +-- See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735
> +-- (Print version and JIT status to stdout, not stderr.).
> +-- This behavior is the same as in Lua 5.2.
> +-- See also https://github.com/tarantool/tarantool/issues/5687.
> +-- This function is adapted from PUC-Rio Lua 5.2 test suite.
> +-- It is used for test commands with -i flag.

<snipped>

> -- 
> 2.33.0
> 

-- 
Best regards,
IM