[Tarantool-patches] [PATCH 2/2] gdb: add mmudata value to lj-gc output
Igor Munkin
imun at tarantool.org
Fri Feb 11 22:12:08 MSK 2022
Sergey,
Thanks for your review!
On 09.02.22, Sergey Kaplun wrote:
> Hi, Igor!
>
> Thanks for the patch!
>
> LGTM, except a single nit regarding commit message below.
Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun at tarantool.org>
>
> On 01.02.22, Igor Munkin wrote:
> > As a result of this patch <g->gc.mmudata> value representing the amount
> > of GC object to be finalized is added to <lj-gc> output. All auxiliary
>
> Typo: s/to <lj-gc> output/to the <lj-gc> output/
Well, I almost sure there is no need for the definite article here.
Ignoring.
>
> > routines are also adjusted a bit since these GC objects are grouped in a
> > ring-list.
> >
<snipped>
>
> --
> Best regards,
> Sergey Kaplun
--
Best regards,
IM
More information about the Tarantool-patches
mailing list