[Tarantool-patches] [PATCH luajit v2] memprof: report JIT-side allocations as internal

Igor Munkin imun at tarantool.org
Wed Feb 2 20:26:35 MSK 2022


Misha,

Thanks for the patch! LGTM, except the single nit.

On 21.08.21, Mikhail Shishatskiy wrote:
> Hi, Sergey!
> Thanks for the review!
> 

<snipped>

> +
> + -- Test for marking JIT-related allocations as internal.
> + -- See also https://github.com/tarantool/tarantool/issues/5679.
> + subtest:ok(alloc[0] == nil)

As a result of the changes made in scope of #5814, this line need to be
adjusted the following way:
| subtest:ok(alloc.line[0] == nil)

> +
> + -- Run already generated traces.

<snipped>

> 
> Best regards,
> Mikhail Shishatskiy

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list