[Tarantool-patches] [RFC v29 0/3] qsync: implement packet filtering (part 1)
Cyrill Gorcunov
gorcunov at gmail.com
Tue Feb 1 00:55:51 MSK 2022
Guys, here is an updated version, where test is converted into luatest
form and box_issue_promote/issue_demote are fenced out with a lock.
Take a look please. It is still RFC since I didn't managed yet to
enhance the test for promote/demote requests as Serge suggested.
Still I would like to make sure that except the test there is
nothing i forget to address from previsous comments.
v22 (by SergeP):
- use limbo emptiness test _after_ owner_id test
- drop redundant assert in limbo commit/rollback
since we're unlocking a latch anyway where own
assertion present
- in test: drop excessive wait_cond and setup wal
delay earlier
v23 (by SergeP):
- fix problem with owner test in case of recovery journal
- update test
v27:
- simplify the code and cover the case targeting journal
write plus terms access race only
- i've spent almost a few months trying to use fine grained
locking scheme for limbo but it end up in very complex code
so eventually I dropped this idea (here why we've v27 after v23)
v29:
- rework test into luaform
- drop fine-grained locks idea since it requires too much code churn,
instead lets fence out a big code parts
branch gorcunov/gh-6036-rollback-confirm-29-notest
issue https://github.com/tarantool/tarantool/issues/6036
previous series https://lists.tarantool.org/tarantool-patches/20211230202347.353494-1-gorcunov@gmail.com/#r
Cyrill Gorcunov (3):
latch: add latch_is_locked helper
qsync: order access to the limbo terms
test: add gh-6036-qsync-order test
src/box/applier.cc | 6 +-
src/box/box.cc | 8 +-
src/box/lua/info.c | 4 +-
src/box/txn_limbo.c | 18 ++-
src/box/txn_limbo.h | 52 ++++++-
src/lib/core/latch.h | 11 ++
.../gh_6036_qsync_order_test.lua | 137 ++++++++++++++++++
test/replication-luatest/suite.ini | 1 +
8 files changed, 226 insertions(+), 11 deletions(-)
create mode 100644 test/replication-luatest/gh_6036_qsync_order_test.lua
base-commit: b72a5c6a1b66d983ca58ac73ecc147e5ab8dd5b3
--
2.34.1
More information about the Tarantool-patches
mailing list