[Tarantool-patches] [PATCH luajit] x64/LJ_GC64: Fix type-check-only variant of SLOAD.

Sergey Kaplun skaplun at tarantool.org
Fri Dec 16 11:13:02 MSK 2022


Hi, Sergos!

Thanks for the review!

On 15.12.22, sergos wrote:
> Hi!
> 
> Thanks for the patch!
> 
> LGTM with fixes after Max’s review. 
> 
> Although, as we discussed earlier I would prefer the test has
> `skipcond(not ffi.abi('gc64’), 'test is GC64 only')`

Discussed with Igor offline and agreed to test this code flow for GC64
and non-GC64 modes.
So, ignoring.

> 
> regards,
> Sergos
> 

<snipped>

> 

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list