[Tarantool-patches] [PATCH luajit 3/2] test: remove TAP side effects in getmetrics tests
Sergey Kaplun
skaplun at tarantool.org
Mon Dec 5 11:01:08 MSK 2022
Hi, Igor!
Thanks for the patch!
LGTM, except a few nits regarding the commit message.
On 02.12.22, Igor Munkin wrote:
> Sometimes TAP functions become hot spots for JIT compiler and the
> corresponding traces spoils test assertions with their side effects.
Typo: s/spoils/spoil/
> To avoid such misbehaviour and fix fragile test, <misc.getmetrics> is
> explicitly called in this particular case. There is no need to fix the
> corresponding test for Lua C API interface, since there is no TAP
Typo: s/Lua C API/the Lua C API/
Typo: s/is/are/
> helpers used to check whether <jit_snap_restore> is counted right. There
> is also no need to fix other subtests nearby, since their assertions are
> no affected by TAP helpers side effects.
>
> Relates to tarantool/tarantool#7762
>
> Signed-off-by: Igor Munkin <imun at tarantool.org>
> ---
<snipped>
> --
> 2.34.0
>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list