[Tarantool-patches] [PATCH luajit 2/2] test: relax JIT setup in misc.getmetrics test
Sergey Kaplun
skaplun at tarantool.org
Mon Dec 5 10:57:11 MSK 2022
Hi, Igor!
Thanks for the patch!
LGTM, except a single nit regarding the commit message.
On 01.12.22, Igor Munkin wrote:
> To test whether <jit_snap_restore> metric is counted right for side
> exits <minstitch> JIT engine parameter is tighted to prevent side trace
> compilation (considering <math.fmod> being used for the corresponding
> branch of execution, the side trace will try to compile with stitching).
> However, if test is run on the platform configured with the option
Typo: s/test/the test/
> LUAJIT_ENABLE_CHECKHOOK enabled, the resulting trace exceeds the
> hardcoded <minstitch> limit and the metric is miscounted due to this new
> trace. To resolve this issue <minstitch> limit is set to the maximum
> amount of IRRef in the trace, preventing trace compilation for any
> LuaJIT configuration.
>
> Relates to tarantool/tarantool#7762
>
> Signed-off-by: Igor Munkin <imun at tarantool.org>
> ---
> test/tarantool-tests/misclib-getmetrics-capi.test.lua | 7 +++++--
> test/tarantool-tests/misclib-getmetrics-lapi.test.lua | 7 +++++--
> test/tarantool-tests/utils.lua | 9 +++++++++
> 3 files changed, 19 insertions(+), 4 deletions(-)
>
<snipped>
> --
> 2.34.0
>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list