[Tarantool-patches] [PATCH luajit 7/8] ci: merge x86_64 and ARM64 workflows
Igor Munkin
imun at tarantool.org
Wed Aug 31 19:02:06 MSK 2022
Sergey,
Thanks for your review!
On 18.08.22, Sergey Kaplun wrote:
> Hi, Igor!
>
> Thanks for the patch!
> LGTM!
>
> On 11.08.22, Igor Munkin wrote:
> > As a result of the previous commit, there is no difference left between
> > x86_64 and ARM64 workflows except the runner where workflow is run.
> > Hence there is no reason to have a separate workflow file for each
> > hardware architecture.
> >
> > Signed-off-by: Igor Munkin <imun at tarantool.org>
> > ---
> > .github/workflows/linux-aarch64.yml | 83 -----------------
> > .../workflows/{linux-x86_64.yml => linux.yml} | 52 ++++++++---
> > .github/workflows/macos-m1.yml | 92 -------------------
> > .../workflows/{macos-x86_64.yml => macos.yml} | 52 ++++++++---
> > 4 files changed, 82 insertions(+), 197 deletions(-)
> > delete mode 100644 .github/workflows/linux-aarch64.yml
> > rename .github/workflows/{linux-x86_64.yml => linux.yml} (69%)
> > delete mode 100644 .github/workflows/macos-m1.yml
> > rename .github/workflows/{macos-x86_64.yml => macos.yml} (73%)
> >
<snipped>
> > @@ -65,8 +77,8 @@ jobs:
> > run: cmake --build . --parallel --target test
> > working-directory: ${{ env.BUILDDIR }}
> >
> > - test-tarantool-debug-wo-GC64:
> > - name: Tarantool Debug GC64:OFF
> > + test-tarantool-x86_64-debug-wo-GC64:
>
> Side note: Can we use the same matrix approach for integration
> workflows?
Unfortunately, we can't: reusable workflows doesn't support matrix
approach (as I've already mentioned here[1]).
>
> > + name: Tarantool x86_64 Debug GC64:OFF
> > needs: test-luajit
> > uses: tarantool/tarantool/.github/workflows/luajit-integration.yml at master
> > with:
<snipped>
> > --
> > 2.34.0
> >
>
> --
> Best regards,
> Sergey Kaplun
[1]: https://lists.tarantool.org/tarantool-patches/YrzPiTa7FyNFKbbW@tarantool.org/
--
Best regards,
IM
More information about the Tarantool-patches
mailing list