[Tarantool-patches] [PATCH luajit 6/8] ci: remove arch prefix for macOS M1 workflow

Igor Munkin imun at tarantool.org
Wed Aug 31 18:55:27 MSK 2022


Sergey,

Thanks for your review! I've fixed all your comments, see the new commit
message at the bottom.

On 18.08.22, Sergey Kaplun wrote:
> Hi, Igor!
> 
> Thanks for the patch!
> 
> LGTM, except a single nit regarding the commit message.
> 
> On 11.08.22, Igor Munkin wrote:
> > Finally self-hosted GitHub Actions runners support Apple M1 hardware. As
> 
> Side note: Is there any link or an announcement of it?

Added.

> 
> > a result there is no need to explicitly add `arch -arm64` prefix for all
> 
> Typo: s/As a result/As a result,/

Fixed.

> 
> > commands being run in scope of macOS M1 workflows.
> > 
> > Signed-off-by: Igor Munkin <imun at tarantool.org>
> > ---
> >  .github/workflows/macos-m1.yml | 19 +++++++------------
> >  1 file changed, 7 insertions(+), 12 deletions(-)
> > 
> > diff --git a/.github/workflows/macos-m1.yml b/.github/workflows/macos-m1.yml
> > index d5b0e0f1..4e1275f7 100644
> > --- a/.github/workflows/macos-m1.yml
> > +++ b/.github/workflows/macos-m1.yml
> 
> <snipped>
> 
> > -- 
> > 2.34.0
> > 
> 
> -- 
> Best regards,
> Sergey Kaplun

| ci: remove arch prefix for macOS M1 workflow
|
| Finally self-hosted GitHub Actions runners support Apple M1 hardware[1].
| As a result, there is no need to explicitly add `arch -arm64` prefix for
| all commands being run in scope of macOS M1 workflows.
|
| [1]: https://github.blog/changelog/2022-08-09-github-actions-self-hosted-runners-now-support-apple-m1-hardware/

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list