[Tarantool-patches] [PATCH luajit] Fix overflow check in unpack().
Sergey Kaplun
skaplun at tarantool.org
Tue Aug 23 16:38:00 MSK 2022
Hi, Sergos!
Thanks for the review!
On 23.08.22, sergos wrote:
> Hi Sergey!
>
> Thanks for the patch, LGTM.
>
> Sergos.
>
>
> > On 23 Aug 2022, at 11:06, Sergey Kaplun <skaplun at tarantool.org> wrote:
> >
> > From: Mike Pall <mike>
> >
> > Thanks to HybridDog.
Added the following forgotten title as usual:)
| (cherry picked from commit 179cf2eb84fef2b9a524469c3c8cc49363b8fb10)
Branch is force-pushed.
> >
> > When build with optimization compiler may throw away overflow check in
> > `unpack()` base library function.
> >
> > This patch prevents aforementioned error by comparing the unsigned
> > amount of values to unpack with `LUAI_MAXCSTACK` instead of 0.
> >
> > Sergey Kaplun:
> > * added the description and the test for the problem
> >
> > Part of tarantool/tarantool#7230
> > ---
> >
> > Issue/PR:
> > * https://github.com/LuaJIT/LuaJIT/pull/574
> > * https://github.com/tarantool/tarantool/issues/7230
> > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-574-overflow-unpack-full-ci
> > PR: https://github.com/tarantool/tarantool/pull/7596
> >
<snipped>
> > 2.34.1
> >
>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list