[Tarantool-patches] [PATCH luajit v6 0/2] memprof: C-symbols resolving
Sergey Kaplun
skaplun at tarantool.org
Mon Apr 4 11:45:52 MSK 2022
Hi, Maxim!
Thanks for the fixes.
On 22.03.22, Maxim Kokryashkin wrote:
> Changes in v6:
> - Fixed comments as per review by Sergey
> - Added tests for newly loaded symbols resolution
>
> ---
> >> +#include <stdlib.h>
> >> +#include <string.h>
> >
> > <string.h> and <stdlib.h> are included inside lj_def.h, so this include is excess.
> Relying on includes in other header files is a terrible practice. Ignoring.
Yes, but it is common for LuaJIT. :)
>
<snipped>
>
> --
> 2.35.1
>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list