[Tarantool-patches] [PATCH v1 1/1] schema: remove assert on wrong insert into _priv

Mergen Imeev imeevma at tarantool.org
Wed Sep 29 09:32:07 MSK 2021


Hi! I'm very sorry! I rebased and pushed:
https://github.com/tarantool/tarantool/tree/imeevma/gh-6295-assert-on-insert-with-wrong-id

On Tue, Sep 28, 2021 at 12:33:02AM +0200, Vladislav Shpilevoy wrote:
> Hi! Thanks for the fixes!
> 
> On 27.09.2021 08:41, Mergen Imeev wrote:
> > Hi!
> > 
> > On 09.09.2021 14:07, Mergen Imeev wrote:
> >> Hi! Thank you for the review! My answers, diff and new patch below.
> >>
> >> On Tue, Sep 07, 2021 at 11:59:58PM +0200, Vladislav Shpilevoy wrote:
> >>> Hi! Thanks for the patch!
> >>>
> >>> See 4 comments below.
> >>>
> >>> On 06.09.2021 10:11, imeevma at tarantool.org wrote:
> >>>> Prior to this patch, an assertion was throwed if a tuple with an
> >>> 1. throwed -> thrown.
> >>>
> >> Fixed.
> 
> I still see it on the branch.
> 
> >>>> incorrect id was inserted into the _priv system space. This bug
> >>>> appeared only in the debug build.
> >>>>
> >>>> Closes #6295
> >>>> ---
> >>>> https://github.com/tarantool/tarantool/issues/6295
> >>>> https://github.com/tarantool/tarantool/tree/imeevma/gh-6295-assert-on-insert-with-wrong-id
> >>> 2. Could you please add a changelog?
> >>>
> >> Added.
> 
> Not on the branch.
> 
> Are you sure you pushed the new version?


More information about the Tarantool-patches mailing list