[Tarantool-patches] [PATCH v1 12/13] sql: remove copying of result in finalizers

Mergen Imeev imeevma at tarantool.org
Tue Sep 21 13:49:40 MSK 2021


Thank you for the review!

On Tue, Sep 14, 2021 at 11:24:18PM +0200, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> Shouldn't you also delete the sizeof(Mem) from the context size
> in sql_context_new()?
No, but I will change from sizeof(struct Mem) to sizeof(struct Mem *). Also,
I will completely drop argv from struct sql_context in the new patch.



More information about the Tarantool-patches mailing list