[Tarantool-patches] [PATCH v4 00/16] sql: refactor aggregate functions

imeevma at tarantool.org imeevma at tarantool.org
Tue Oct 26 13:34:02 MSK 2021


This patch-set refactor the aggregate functions and does some refactoring of the
SQL function infrastructure as a whole.

https://github.com/tarantool/tarantool/issues/4145
https://github.com/tarantool/tarantool/tree/imeevma/gh-4145-aggregate-functions

Changes in v2:
 - Added commit to remove possible UB in int-to-double implicit cast function.
 - Added commit to drop argv from struct sql_context.
 - Review fixes.

Changes in v3:
 - All functional changes were carried over from this patch-set. All that's left
   is refactoring.

Changes in v4:
 - Zeroblob optimization was removed, which allowed to simplify code and avoid
   some errors.

Mergen Imeev (16):
  sql: remove MEM_Zero flag from struct MEM
  sql: fix possible undefined behavior during cast
  sql: use register P1 for number of arguments
  sql: remove AggStep0 and OP_BuiltinFunction0
  sql: move collation to struct sql_context
  sql: introduce mem_append()
  sql: remove sql_vdbemem_finalize()
  sql: refactor SUM() function
  sql: refactor TOTAL() function
  sql: refactor AVG() function
  sql: refactor COUNT() function
  sql: refactor MIN() and MAX() functions
  sql: refactor GROUP_CONCAT() function
  sql: remove copying of result in finalizers
  sql: remove MEM_TYPE_AGG
  sql: remove field argv from struct sql_context

 .../gh-6113-fix-segfault-in-hex-func.md       |   4 +
 src/box/sql/date.c                            |  43 -
 src/box/sql/expr.c                            |  19 +-
 src/box/sql/func.c                            | 806 ++++++++----------
 src/box/sql/main.c                            |   5 +-
 src/box/sql/mem.c                             | 200 +----
 src/box/sql/mem.h                             |  57 +-
 src/box/sql/select.c                          |  35 +-
 src/box/sql/sqlInt.h                          |  40 +-
 src/box/sql/vdbe.c                            | 202 +----
 src/box/sql/vdbeInt.h                         |   7 +-
 src/box/sql/vdbeapi.c                         | 108 ---
 src/box/sql/vdbeaux.c                         |  21 +-
 test/sql-tap/engine.cfg                       |   1 +
 ...gh-6113-assert-in-hex-on-zeroblob.test.lua |  13 +
 15 files changed, 524 insertions(+), 1037 deletions(-)
 create mode 100644 changelogs/unreleased/gh-6113-fix-segfault-in-hex-func.md
 create mode 100755 test/sql-tap/gh-6113-assert-in-hex-on-zeroblob.test.lua

-- 
2.25.1



More information about the Tarantool-patches mailing list