[Tarantool-patches] [PATCH v1 01/21] sql: refactor CHAR() function

[Vladislav Shpilevoy]

Hi! Thanks for the patch!

Before this commit on the branch I see a comment called 'Fix'.
Please, cleanup the branch from unfinished work.

On 08.10.2021 19:31, imeevma at tarantool.org wrote:
> Part of #4145
> ---
>  src/box/sql/func.c | 85 ++++++++++++++++++++++------------------------
>  1 file changed, 40 insertions(+), 45 deletions(-)
> 
> diff --git a/src/box/sql/func.c b/src/box/sql/func.c
> index a3c7d8d20..dd5e7d785 100644
> --- a/src/box/sql/func.c
> +++ b/src/box/sql/func.c
> @@ -738,6 +738,45 @@ func_substr_characters(struct sql_context *ctx, int argc, struct Mem *argv)
>  		ctx->is_aborted = true;
>  }
>  
> +/** Implementation of the CHAR() function. */

Please, keep the comments explaining what the non-trivial functions do.

> +static void
> +func_char(struct sql_context *ctx, int argc, struct Mem *argv)
> +{